chore(dep): update benchpress for compat with protractor in de… #1229
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular/angular#2592 The selenium webdriver API changed between protractor 2.3 and 2.4. This affects benchpress, and has since been fixed in the angular repo. Update version of benchpress in package.json Fixes ReactiveX#1228
|
Thanks for catching - can you share snippet of benchmark results after this update? |
| @@ -90,7 +90,7 @@ | |||
| "homepage": "https://github.com/ReactiveX/RxJS", | |||
| "devDependencies": { | |||
| "benchmark": "1.0.0", | |||
| "benchpress": "2.0.0-alpha.37.2", | |||
| "benchpress": "^2.0.0-beta.1", | |||
There was a problem hiding this comment.
would you able to remove ^ for dependency version? currently we're trying to have fixed version dependency with known good version and manually increment its version if update is verified.
There was a problem hiding this comment.
I'll close and reopen PR, I screwed up too many things here. Linked to wrong issue in commit message too. 😢
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vDep. See angular/angular#2592
The selenium webdriver API changed between protractor 2.3 and 2.4. This affects benchpress, and has since been fixed in the angular repo. Update version of benchpress in package.json
Fixes #1228